Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would you be willing to add a custom template engine? #9

Open
cbmdfc opened this issue Jan 27, 2022 · 1 comment
Open

Would you be willing to add a custom template engine? #9

cbmdfc opened this issue Jan 27, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@cbmdfc
Copy link

cbmdfc commented Jan 27, 2022

Thank you for this tool!

Would you be willing to consider adding another template engine besides go one? like gobuffalo/plush?

you would be bringing lots of features like function declaration within the language and far more customization

@patrickdappollonio patrickdappollonio self-assigned this Feb 2, 2022
@patrickdappollonio
Copy link
Owner

Hey! I'm so sorry I didn't answer fast enough here...

I think in order to do this, there would be a few questions to discuss, like:

  1. Do we do this using a flag for the language or we detect it from the file? I think declaratively, it shouldn't be pre-detected because that would break backwards compatibility if, say, you're trying to render a template-to-plush file, so an env var or a flag (like --plush or similar) would work best.

  2. Will plush be enough? This might potentially open the requirement for other template engines to make the cut, and at that point, we would have to veto those. I've heard for example people would want a Jinja or Handlebars (which looks close to Go!) template engine too, but then some of the functions globally available for normal Go templates might not be needed in, say, Plush or Jinja, and at that point it becomes a disparity.

Would love to know more what you think about it though!

@patrickdappollonio patrickdappollonio added the enhancement New feature or request label Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants