Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drops columns when cleaning pathways.txt #12

Open
derhuerst opened this issue Dec 3, 2021 · 3 comments
Open

drops columns when cleaning pathways.txt #12

derhuerst opened this issue Dec 3, 2021 · 3 comments

Comments

@derhuerst
Copy link

derhuerst commented Dec 3, 2021

I'm using gtfs-hub to transform the DELFI GTFS feed, and gtfstidy drops columns:

cd gtfs-hub
mkdir -p data/gtfs
make data/gtfs/DELFI.tidied.gtfs
# tidying DELFI.raw GTFS feed using Patrick Brosi's gtfstidy
# docker run -i --rm -v $PWD/data/gtfs:/data/gtfs derhuerst/gtfstidy --fix -o /data/gtfs/DELFI.tidied.gtfs /data/gtfs/DELFI.raw.gtfs
# Parsing GTFS feed in '/data/gtfs/DELFI.raw.gtfs' ... done. (0 trips [0.00%], 139 stops [0.03%], 872 shapes [0.01%], 0 services [0.00%], 0 routes [0.00%], 0 agencies [0.00%], 255 transfers [0.03%], 0 pathways [0.00%], 0 levels [0.00%], 0 fare attributes [0.00%] dropped due to errors. Use -W to display them.)
# Outputting GTFS feed to '/data/gtfs/DELFI.tidied.gtfs'...

head -n 1 data/gtfs/DELFI.raw.gtfs/pathways.txt
# "pathway_id","from_stop_id","to_stop_id","pathway_mode","is_bidirectional","traversal_time","length","stair_count","max_slope","min_width"
head -n 1 data/gtfs/DELFI.tidied.gtfs/pathways.txt
# pathway_id,from_stop_id,to_stop_id,pathway_mode,is_bidirectional,length,traversal_time
@patrickbr
Copy link
Owner

Do the pathway.txt columns have any non-default values? gtfstidy drops any column that is completely empty or only filled with the GTFS default values :)

@derhuerst
Copy link
Author

AFAIR they don't contain any values, so semantically it's fine, but validators stumble over this.

@patrickbr
Copy link
Owner

Hm, but only pathway_id, from_stop_id, to_stop_id, pathway_mode and is_bidirectional are required values for pathways.txt, the others are optional, so IMHO this should be fixed in the validator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants