Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Parse.nodeLogging to fully log Parse.Object #1594

Open
wants to merge 1 commit into
base: alpha
Choose a base branch
from

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Nov 3, 2022

New Pull Request Checklist

Issue Description

Currently, when logging a Parse.Object in NodeJS, the only thing that is logged is ParseObject { _objCount: 376, className: 'Person' }, which more often than not isn't overly helpful.

Related issue: n/a

Approach

Adds Parse.nodeLogging which logs the object out to:

ParseObject: className: Person, id: undefined
Attributes: {
  "foo": "bar"
}

TODOs before merging

  • Add tests

@parse-github-assistant
Copy link

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Related issue: #123 in the PR description, so I can recognize it.

@mtrezza
Copy link
Member

mtrezza commented Nov 3, 2022

Does this influence existing built-in log messages? If so, maybe this should be optional, because logging object attributes may expose sensitive data in the logs.

@dblythy
Copy link
Member Author

dblythy commented Nov 3, 2022

Yes it does, that's why it defaults to false at the moment

@mtrezza
Copy link
Member

mtrezza commented Nov 3, 2022

Alright, maybe we can add a short warning note about that to the option JSdoc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants