Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CI/CD #19

Open
liamaharon opened this issue Aug 15, 2023 · 2 comments
Open

Improve CI/CD #19

liamaharon opened this issue Aug 15, 2023 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@liamaharon
Copy link
Contributor

liamaharon commented Aug 15, 2023 •
edited
Loading

CI/CD is pretty rudimentary and slow at the moment.

Need to set up some kind of caching for the builds.
@liamaharon liamaharon added the enhancement New feature or request label Aug 15, 2023
@liamaharon liamaharon mentioned this issue Aug 15, 2023
Merged
16 tasks
@liamaharon liamaharon added the help wanted Extra attention is needed label Aug 28, 2023
@simonsso
Copy link
Contributor

simonsso commented Nov 1, 2023

action-rs/cargo is also unmaintained since long time.

@eagr
Copy link
Contributor

eagr commented Nov 12, 2023 •
edited
Loading

The CI is green but is somewhat broken.

try-runtime-cli/.github/workflows/rust-checks.yaml

Lines 19 to 22 in fd0ec95

- uses: actions-rust-lang/setup-rust-toolchain@v1
with:
toolchain: nightly
components: rustfmt

If you take a look at the related CI output, stable is installed of nightly.
https://github.com/paritytech/try-runtime-cli/actions/runs/6822899922/job/18555792000#step:3:122

Surprised? This is really not a good design. I'd probably just use dtolnay's version, which they're trying to imitate but did a bad job with it.

Also, their actions-rust-lang/rustfmt@v1 does all the fancy stuff but doesn't provide an option for cargo +nightly fmt which is a common practice. And there's more.. These all reflect bad judgements. We should probably just stop using their code..

@eagr eagr mentioned this issue Nov 12, 2023
Merged
liamaharon pushed a commit that referenced this issue Nov 16, 2023
@eagr
Update CI Rust checks (#57)
fd2b5ef 
helps #19

summary
* use `dtolnay/rust-toolchain` instead
* use nightly for both fmt and clippy, for the latest features
* `clippy -- --deny warnings` (let me know if this isn’t what you want)
* use matrix for testing (easier to add more targets)

I combined fmt and clippy into one job so that we don’t have to repeat
the checkout-install ceremony. Also coz by definition linting does
address stylistic errors. :)) But if you don’t like it, I could split
them, no problem.

Curious, is there a reason why we’re using `ubuntu-20.04` instead of
`ubuntu-latest`?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@simonsso @liamaharon @eagr