Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix encointer AURA slot #101

Open
ggwpez opened this issue Oct 7, 2024 · 0 comments
Open

Fix encointer AURA slot #101

ggwpez opened this issue Oct 7, 2024 · 0 comments

Comments

@ggwpez
Copy link
Member

ggwpez commented Oct 7, 2024 •
edited
Loading

Something wrong, probably here:

try-runtime-cli/core/src/common/empty_block/inherents/providers.rs

Line 126 in 251438f

SlotDuration::from_millis(self.blocktime.as_millis() as u64), 

panicked at /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cumulus-pallet-aura-ext-0.15.0/src/consensus_hook.rs:69:9:
    assertion `left == right` failed: slot number mismatch
      left: Slot(143998834)
     right: Slot(287997668)
thread 'main' panicked at cli/main.rs:326:10:

Looks like it is off by 2x, occurred here: https://github.com/polkadot-fellows/runtimes/actions/runs/11168344347/job/31047391625?pr=463

We do have the --blocktime flag, but i think its not being used here.
ggwpez added a commit to polkadot-fellows/runtimes that referenced this issue Oct 8, 2024
@ggwpez
Disable MBM checking for encointer-kusama since it wont work
4617cfd 
TODO paritytech/try-runtime-cli#101

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez ggwpez mentioned this issue Oct 8, 2024
Merged
1 task
fellowship-merge-bot bot added a commit to polkadot-fellows/runtimes that referenced this issue Oct 18, 2024
@ggwpez @fellowship-merge-bot @bkchr
Update try-runtime-cli (#463)
91a4498 
- Update try-runtime-cli for MBM testing that was added
paritytech/try-runtime-cli#90
- Fix KAH spec version that was incorrectly bumped
- Disable MBM testing for Encointer runtime until
paritytech/try-runtime-cli#101 is fixed
(single-block-migrations are still checked).

- [x] Does not require a CHANGELOG entry

---------

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: fellowship-merge-bot[bot] <151052383+fellowship-merge-bot[bot]@users.noreply.github.com>
Co-authored-by: Bastian Köcher <[email protected]>
@ggwpez ggwpez mentioned this issue Nov 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ggwpez