From 7125cb244556a70a531892091ad4ea0a003cfff5 Mon Sep 17 00:00:00 2001
From: Liam Aharon <liam.aharon@hotmail.com>
Date: Mon, 30 Oct 2023 19:44:32 +1100
Subject: [PATCH] Exit with non-zero code when there are weight warnings (#46)

---
 Cargo.lock                              | 4 ++--
 Cargo.toml                              | 2 +-
 core/src/commands/on_runtime_upgrade.rs | 2 ++
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/Cargo.lock b/Cargo.lock
index a86bdabe7d5..ed92bdd41a1 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -11262,7 +11262,7 @@ checksum = "3528ecfd12c466c6f163363caf2d02a71161dd5e1cc6ae7b34207ea2d42d81ed"
 
 [[package]]
 name = "try-runtime-cli"
-version = "0.3.3"
+version = "0.3.4"
 dependencies = [
  "clap",
  "env_logger",
@@ -11314,7 +11314,7 @@ dependencies = [
 
 [[package]]
 name = "try-runtime-core"
-version = "0.3.3"
+version = "0.3.4"
 dependencies = [
  "assert_cmd",
  "async-trait",
diff --git a/Cargo.toml b/Cargo.toml
index 1df98d27f82..de255c55d55 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -7,7 +7,7 @@ members = [
 ]
 
 [workspace.package]
-version = "0.3.3"
+version = "0.3.4"
 authors = ["Parity Technologies <admin@parity.io>"]
 description = "Substrate's programmatic testing framework."
 edition = "2021"
diff --git a/core/src/commands/on_runtime_upgrade.rs b/core/src/commands/on_runtime_upgrade.rs
index c15d2c1ad0f..f1be9473c48 100644
--- a/core/src/commands/on_runtime_upgrade.rs
+++ b/core/src/commands/on_runtime_upgrade.rs
@@ -144,6 +144,8 @@ where
         _ => {
             log::warn!(target: LOG_TARGET, "⚠️  TryRuntime_on_runtime_upgrade executed \
             successfully but with weight safety warnings.");
+            // Exit with a non-zero exit code to indicate that the runtime upgrade may not be safe.
+            std::process::exit(1);
         }
     }