-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
polkadot-sdk-docs: Use command_macro! #6624
base: master
Are you sure you want to change the base?
Conversation
Can you please use |
@iulianbarbu, I used a slightly modified version of the macro used in |
docs/sdk/src/reference_docs/chain_spec_runtime/tests/chain_spec_builder_tests.rs
Outdated
Show resolved
Hide resolved
docs/sdk/src/reference_docs/chain_spec_runtime/tests/chain_spec_builder_tests.rs
Outdated
Show resolved
Hide resolved
Bot fmt and label needed 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is almost there I think, thanks!
docs/sdk/src/reference_docs/chain_spec_runtime/tests/chain_spec_builder_tests.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ndkazu , one small remark related to the PRDOC.
docs/sdk/src/reference_docs/chain_spec_runtime/tests/chain_spec_builder_tests.rs
Outdated
Show resolved
Hide resolved
@iulianbarbu it's done: Thank you for the mentoring during this PR⇒ I learned a lot!!!! |
Description
Understood assignment:
Initial assignment description is in #6194 : find every occurrence of
#[docify::export]
whereprocess:Command
is used → replace the use ofprocess:Command
bycommand_macro!
Issues observed:
#[docify::export]
&process:Command
are failing to begin with (tested & worked on:~/polkadot-sdk/docs/sdk/src/reference_docs/chain_spec_runtime/tests/chain_spec_builder_tests.rs
)command_macro
the following file needed some modifications:~/.cargo/registry/src/index.crates.io-6f17d22bba15001f/command-macros-plugin-0.2.7/src/lib.rs
I am running
cargo +nightly test
from~/polkadot-sdk/docs/sdk/src/reference_docs/chain_spec_runtime/
Same test failures are observed after changing from
process:Command
tocommand_macro!
Some assistance is needed.