-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stake tracker improvements (migration and try-state checks OK in Polkadot) #4673
Merged
gpestana
merged 18 commits into
gpestana/stake-tracker_integration
from
gpestana/stake-tracker_integration-ext-stable
Jun 3, 2024
Merged
Stake tracker improvements (migration and try-state checks OK in Polkadot) #4673
gpestana
merged 18 commits into
gpestana/stake-tracker_integration
from
gpestana/stake-tracker_integration-ext-stable
Jun 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…=westend --target_dir=polkadot --pallet=pallet_staking
…=westend --target_dir=polkadot --pallet=pallet_staking
gpestana
changed the title
Gpestana/stake tracker integration ext stable
Stake tracker improvements (migration and try-state checks OK in Polkadot)
Jun 3, 2024
gpestana
merged commit Jun 3, 2024
6219b32
into
gpestana/stake-tracker_integration
18 of 41 checks passed
This was referenced Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in the migration code introduced in this PR:
fn do_add_nominator
with dedup nominations)fn do_add_nominator
if necessary)Nominators
map first and through all theValidators
map to insert all the validators that are not nominated to the target list (with self-stake only).The migration code has been validated against the Polkadot using the externalities tests in polkadot/runtime/westend/src/lib.rs. Upon running the migrations, we ensure that:
Note: Same as #4436 but with a non-messed up git history. Merging into
gpestana/stake-tracker_integration
.