Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature flags serde_full and/or decode #39

Open
clangenb opened this issue Jun 22, 2022 · 3 comments
Open

Add feature flags serde_full and/or decode #39

clangenb opened this issue Jun 22, 2022 · 3 comments

Comments

@clangenb
Copy link

Neither Decode nor Deserializing are derived in no_std, which would be very beneficial to us. At a first glance, this should not be a problem with the substrate or scale-info types.

Are you open to this?

@gilescope
Copy link
Contributor

gilescope commented Jul 16, 2022

Seems like this is a blocker to using scale on the web and doing any rust in wasm in browser. Maybe I can decode it myself as I now have https://github.com/gilescope/scale-borrow if I impl borrow_decode for the metadata types. I'm guessing there's no metadata metadata... or is there? I'd need scale-info for the metadata types rather than meta-metadata.

@clangenb
Copy link
Author

I understand what you mean, however, for the newest metadata it would fairly easy, which would probably cover most of the substrate projects. We did this here: scs/substrate-api-client#259

I was about to suggest an upstream PR for this, but I think I need to have a second look at our feature flags.

@gilescope
Copy link
Contributor

gilescope commented Jul 18, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants