Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely on selected port to guide Load To button state. #573

Merged
merged 1 commit into from
Apr 16, 2021

Conversation

zfi
Copy link
Contributor

@zfi zfi commented Apr 16, 2021

Addresses #572.

The toolbar controller has been relying on the first element of the port list to be non-blank to indicate a selected port. This update changes that to rely on the client_connection object as the single source of truth for connection state and queries the object for the current selected port.

@zfi zfi requested a review from pjewald April 16, 2021 20:48
@pjewald pjewald added this to the Release v1.5.8 milestone Apr 16, 2021
Copy link
Collaborator

@pjewald pjewald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lg2m

@pjewald pjewald merged commit 2f9b088 into develop Apr 16, 2021
@pjewald pjewald deleted the patch-ui_toolbar branch April 20, 2021 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants