Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Notify user when launcher closed during active connection #75

Open
zfi opened this issue Oct 1, 2019 · 3 comments
Open

Comments

@zfi
Copy link
Contributor

zfi commented Oct 1, 2019

In v 0.9.8 of the launcher, it is possible to close the launcher regardless of the connected state of the launcher. Would it be possible to open a confirmation dialog window when the launcher is actively connected to a browser session to confirm that the launcher should actually be closed?

@zfi zfi added the enhancement label Oct 1, 2019
@PropGit
Copy link
Contributor

PropGit commented Oct 2, 2019

Good idea. It may be possible- I'll look into it. Chrome Apps have some strict rules about what is possible (and in what timeframe) upon application close - being able to cancel the application close event may be one of the limitations that is hard to get around.

@MatzElectronics
Copy link
Collaborator

MatzElectronics commented Oct 2, 2019 via email

@PropGit
Copy link
Contributor

PropGit commented Oct 4, 2019

Not in a Chrome App; that event seems to not be triggered, or somehow circumvented. Just tried it.

I don't think there's a way to do this in a Chrome App, based on everything I've been reading. The Chrome App lifecycle is this:

image

It does not good to handle the onSuspend() because the window is closed and the process will be terminated very soon. onSuspend() is for quick cleanup.

I think we can only achieve this through nwjs, which has a feature for this enhancement; however, that will only work on Windows/Mac/Linux, not Chromebooks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants