Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Violations on console #1677

Open
PropGit opened this issue May 24, 2019 · 7 comments
Open

Multiple Violations on console #1677

PropGit opened this issue May 24, 2019 · 7 comments
Labels

Comments

@PropGit
Copy link
Contributor

PropGit commented May 24, 2019

Recent console capture shows violations. Disregard websocket errors, just look for "[violation]" below.

2019-05-24 16_52_25-BlocklyProp

blocklyprop.com-1558709527392.log

@PropGit PropGit added the bug label May 24, 2019
@zfi
Copy link
Contributor

zfi commented May 24, 2019

Any thoughts on what rule is being violated? These all look like timing concerns, so this might be more of a code tuning opportunity rather than an error.

@PropGit
Copy link
Contributor Author

PropGit commented May 24, 2019

The times for setInterval and setTimeout are not crazy, but maybe they are a violation in the context for which they are used which is probably slowing the UI down.

What looks to me to be the problem is the ace editor (non-passive event listener to a scroll-blockling 'mousewheel' event). Maybe there's a ace editor update that already fixes this. The other messages may or may not be related.

Each of these violations may be a new warning feature of Chrome 73 or 74.

@zfi
Copy link
Contributor

zfi commented May 24, 2019

The code packages (ace, bootstrap and jquery) are grossly overdue for updates. We're at least 2 years behind on these. However, they each contain breaking changes in the upgrade path. We must implement these thoughtfully. But soon.

@MatzElectronics
Copy link
Collaborator

MatzElectronics commented May 24, 2019 via email

@MatzElectronics
Copy link
Collaborator

Removing the "bug" label and replacing it with "task" - no functionality is broken currently - and many of these are simply out of our control as they are buried inside of the blocklyprop's dependencies.

@MatzElectronics MatzElectronics added task and removed bug labels May 25, 2019
@MatzElectronics
Copy link
Collaborator

@PropGit @zfi can one of you create a /parallaxinc/ fork of the following so we can start the process of testing to see what it will take to upgrade our dependencies?

jQuery
Ace Editor
Bootstrap
Datatables - not a current dependency, but we'll be switching to this soon

@PropGit
Copy link
Contributor Author

PropGit commented May 28, 2019

Will do, but let's set this task aside until week of 6/3 when @zfi and I are both back and able to follow along and help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants