Site struggles to connect with client

[PropGit]

Yesterday, the Production and Solo sites were updated to v1.3.503 and v1.3.504, respectively.

Today, educators are having trouble in their classes. Some seems to be a caching problem (like many times in the past) but one instructor reports "all of my students are seeing the "Looking for BlocklyProp client" indefinitely, no matter whether or not the client is launched and connected, indefinitely. This persists across computers, robots, and after restarts."

I've seen this kind of connection issue in the past (as if the browser code had been changed somehow) but can't be sure. CTRL+SHIFT+Refresh solves it, but seemingly only if the user waits > 12 seconds on the editor page before refreshing. If they click refresh too early, or click multiple times fairly fast (<12s between), it continue to be "stuck" at "Looking for BlocklyProp client" message.

[PropGit]

The 12 second thing doesn't appear to be consistent. Most of the time, I can't make it connect now.

[PropGit]

IMPORTANT: Solo doesn't seem to be having the same problem. Solo is connecting for me without issue.

[MatzElectronics]

I had this happen in my classroom yesterday morning. It only happened for 3 students and all on chromebooks, but they did eventually connect after a refresh, but it took a minute or two.

…

On Thu, Nov 14, 2019 at 12:14 PM Parallax Git Administrator < ***@***.***> wrote: IMPORTANT: Solo doesn't seem to be having the same problem. Solo is connecting for me without issue. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#232?email_source=notifications&email_token=AEWSVOCIRZWFJLCTT47RSLDQTWWT3A5CNFSM4JNRACU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEDETXI#issuecomment-554060253>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEWSVOCEKZLNGZUVCMUQ6PDQTWWT3ANCNFSM4JNRACUQ> .

[zfi]

The CDN code version that we are running on production is ... prod/14/file.... The browsers should automatically refresh the Javascript because the URI is different. The old one was ...prod/13...

All my tests are loading the correct CDN version.

[PropGit]

Here's a video showing the experience on my side. I've CTRL+SHIFT+refreshed many times on Production (and Solo) before this, so I shouldn't have any cached content.

https://photos.app.goo.gl/6ntsjWdELubz1h1i9

[PropGit]

I remembered what's causing this! We HAVE fixed this before, I'm sure of it; or this is once again a similar kind of problem with yet a different object reference. Here's the error in the console for that video pasted above:

[PropGit]

Looks like it's a similar issue as a previous fix that was done before: Issue #1687

[PropGit]

Actually, this is more direct. It was indeed fixed if I'm reading and remembering this right: Issue #140

[pjewald]

Ok, that makes sense. Code from solo's copy of the CDN has made it's way back into this repo. Not good.

@PropGit Are you able to reproduce the above error consistently? I am going to patch the CDN and want to be able to validate the change.

[pjewald]

I found that there are some artifacts from the Solo CDN code that made its way back into the production BlocklyProp CDN repo. Among those is the refactoring of the projectData global variable to a separate globals.js file. The editor.jsp is not including that new file, so the variable goes missing until it is explicitly assigned a value somewhere.

[PropGit]

Verified. It indeed works for me now. I apologize for missing this request for verification.