-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bind command #31
Comments
After further deliberation, instead of a built-in command. There should be a decorator with a key combination. @Commander()
export ExampleBindableCommand {
@Command()
@Shortcut("LeftAlt+E")
run(ctx: CommandContext) {}
} The type for the shortcut could probably just be imported from react-pretty-hooks, KeyCodes. A better way could probably be deliberated because I know the luau package is planned. |
Instead of a string, the shortcut could be |
You make an excellent point there, it would be easier to test and stub if the type builds of an array. |
I think it might be better to have this as an option passed to |
I am writing a pull request at the moment, it's using the shortcut as an option on the |
I don't know if this is implementable in the current version of commander but I would love to have to option to bind UserInputService / Mouse events to commands. For example tf2 and a lot of source games have the syntax:
bind KEY "command"
I think this would add a lot of customizability, and allow users to tailor build commander around their experience.
The text was updated successfully, but these errors were encountered: