eth_feeHistory returns incorrect fields

[Rjected]

Describe the bug

The rpc-compat test eth_feeHistory fails:

• The oldestBlock is returned as a hash when it is requested by number
• The returned baseFeePerGas is incorrect
• The reward field should exist
• Two gasUsedRatios are returned when only one should be returned - the block_count parameter is 0x1

>>  {"jsonrpc":"2.0","id":1,"method":"eth_feeHistory","params":["0x1","0x2",[95,99]]}
<<  {"jsonrpc":"2.0","result":{"baseFeePerGas":["0x342770c0","0x2db08786"],"gasUsedRatio":[0.0042,0.0042],"oldestBlock":"0x898753d8fdd8d92c1907ca21e68c7970abd290c647a202091181deec3f30a0b2","reward":null},"id":1}
response differs from expected:
 {
   "id": 1,
   "jsonrpc": "2.0",
   "result": {
     "baseFeePerGas": [
-      0: "0x342770c0",
+      1: "0x2806be9d"
     ],
     "gasUsedRatio": [
-      0: 0.0042,
       1: 0.0042
     ],
-    "oldestBlock": "0x898753d8fdd8d92c1907ca21e68c7970abd290c647a202091181deec3f30a0b2",
+    "oldestBlock": "0x2",
-    "reward": null
+    "reward": [
+      : [
+        : "0x1",
+        : "0x1"
+      ]
+    ]
   }
 }

Steps to reproduce

Run the steps in #851, building the docker image in the dan/hive-ci branch.

Command to run the eth_feeHistory tests:

./hive --client reth --sim ethereum/rpc-compat --sim.limit "/eth_feeHistory"

Node logs

No response

Platform(s)

No response

What version/commit are you on?

No response

Code of Conduct

• I agree to follow the Code of Conduct

[sk1122]

can i pick this issue @mattsse?

have did some work already on this and got gasUsedRatio and baseFeePerGas working, now adding more checks like for rewardPercentile, we can't have more than 100, also calculating reward based on that

testing on the hive test suite

[mattsse]

sure! ty

I believe this should be the correct format:

https://github.com/gakonst/ethers-rs/blob/27f895f27ed3f9cf0510a8be8decfb1eee146bb5/ethers-core/src/types/fee.rs#L6

[sk1122]

yes, using the same format, used camelCase here, because it was used in the test 😅

[mattsse]

hey @sk1122

This will become a blocker shortly. Are you still planning to work on it?

[sk1122]

I am working on it, completing rewards and writing test, will try complete it by Sunday(ist)

[mattsse]

awesome, ty!