Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking changes in logging upgrade 1.8.2->2.0.0 #12

Open
djrodgerspryor opened this issue Apr 10, 2015 · 2 comments
Open

Breaking changes in logging upgrade 1.8.2->2.0.0 #12

djrodgerspryor opened this issue Apr 10, 2015 · 2 comments

Comments

@djrodgerspryor
Copy link

Most notably, the Hash.getopt monkey-patch is gone, so initialize now crashes.

See the full diff for logging:
TwP/logging@c1025b6...f7bcda5
djrodgerspryor added a commit to djrodgerspryor/remote_syslog_logger that referenced this issue Apr 10, 2015
@djrodgerspryor
Lock logging gem to < 2.0.0
9158a15 
See issue here: papertrail#12
@djrodgerspryor djrodgerspryor mentioned this issue Apr 10, 2015
Closed
@djrodgerspryor
Copy link
Author

Proposed solution for the short term is just to lock the version of logging: #13

@eric
Copy link
Contributor

eric commented Apr 14, 2015

I think you're actually going to need to make this change to this line: https://github.com/BIAINC/logging-remote-syslog/blob/master/logging-remote-syslog.gemspec#L34

The Gemfile in this project is only used for testing, it doesn't actually get used by rubygems when you include this gem in other projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eric @djrodgerspryor