Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use panoptes-utils SerialDevice in AbstractSerialFocuser #1124

Open
danjampro opened this issue Jun 22, 2021 · 1 comment
Open

Use panoptes-utils SerialDevice in AbstractSerialFocuser #1124

danjampro opened this issue Jun 22, 2021 · 1 comment

Comments

@danjampro
Copy link
Collaborator

danjampro commented Jun 22, 2021

Tests with Birger and Astromechanics focusers on Huntsman have shown that a speed up of ~5x can be achieved by doing this.

See AstroHuntsman/huntsman-pocs#488

@wtgee
Copy link
Member

wtgee commented Jun 23, 2021

I added something to #1125 that might help. Essentially any time the serial class tries to read (either via a direct read or some kind of readline) there is a risk of it waiting for a response from the device unless you give it a hint, which is the first (and only) parameter to those functions (and is the number of bytes to read, even with readline(s). The preferred way to overcome that is to give a hint equal to the in_waiting property, which will default to 0 if nothing is there to be read, otherwise the actual number of bytes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants