Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Flaky ResourceWarning: unclosedssl.SSLSocket #44732

Closed
mroeschke opened this issue Dec 3, 2021 · 2 comments · Fixed by #44775
Closed

CI: Flaky ResourceWarning: unclosedssl.SSLSocket #44732

mroeschke opened this issue Dec 3, 2021 · 2 comments · Fixed by #44775
Labels
CI Continuous Integration Unreliable Test Unit tests that occasionally fail
Milestone

Comments

@mroeschke
Copy link
Member

mroeschke commented Dec 3, 2021

https://github.com/pandas-dev/pandas/runs/4399631223?check_suite_focus=true

AssertionError: Caused unexpected warning(s): [('ResourceWarning', ResourceWarning("unclosed <ssl.SSLSocket fd=8, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6, laddr=('10.1.0.137', 51532), raddr=('52.216.164.101', 443)>"), '', 1043)]

Initial guess: it may be coming from one of our dependencies like boto/boto3#454

Potential solution:
boto/botocore#1810 (comment)
mintel/pytest-localstack#44 (comment)

@mroeschke mroeschke added CI Continuous Integration Unreliable Test Unit tests that occasionally fail labels Dec 3, 2021
@jbrockmendel
Copy link
Member

We already have one special-case in _assert_caught_no_extra_warnings to filter out SSL-related warnings, might as well filter these out too. the time spent on tracking down ResourceWarnings has way exceeded the usefulness

@mroeschke
Copy link
Member Author

+1. Since pandas is not a http library, agreed we should just ignore related artifacts for the stability of the CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Unreliable Test Unit tests that occasionally fail
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants