Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate new Windows introspection library #1085

Closed
rjwhelan opened this issue Sep 3, 2021 · 4 comments · Fixed by #1138
Closed

Integrate new Windows introspection library #1085

rjwhelan opened this issue Sep 3, 2021 · 4 comments · Fixed by #1138
Assignees
Milestone

Comments

@rjwhelan
Copy link
Member

rjwhelan commented Sep 3, 2021

We have a new Windows introspection library we'd like to integrate. This issue will track development.

The goal for the initial PR is to not break existing plugins, but this will leave PANDA with multiple introspection approaches. A future issue will address changes required to consolidate to a single introspection library.

@AndrewFasano AndrewFasano added this to the ll_updates milestone Sep 3, 2021
@AndrewFasano
Copy link
Contributor

The Windows introspection code is split over a few places. I don't know anything about it, but we currently have:

Not sure how your library is designed, but it would be nice if we ended with the code consolidated into a single repo or plugin.

Not sure if your introspection supports Windows 10 - I've heard rumors that it's possible to get Win 10 booting under PANDA. If you're interested in that OS it would be great to get some docs describing how to run it. Or we could just note that as a reason to eventually tackle #570.

@github-actions
Copy link

github-actions bot commented Nov 3, 2021

This issue has gone stale! If you believe it is still a problem, please comment on this issue or it will be closed in 30 days

@Ben-Dumas
Copy link
Contributor

This is being finished up, PR in the next couple days.

@Ben-Dumas Ben-Dumas linked a pull request Dec 2, 2021 that will close this issue
@Ben-Dumas
Copy link
Contributor

Merged. Now requires the user to install https://github.com/panda-re/libosi. We should think of a way to keep PANDA versions in sync with libosi versions if more development happens on libosi (e.g., "libosi v0.1.0 detected, but >v0.2.0 is required"). For now, though, there shouldn't be many (any) changes to libosi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants