Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orbdir has no parameters but is called with a vector refNorm #1

Open
FalcoGer opened this issue Jul 7, 2021 · 3 comments
Open

orbdir has no parameters but is called with a vector refNorm #1

FalcoGer opened this issue Jul 7, 2021 · 3 comments

Comments

@FalcoGer
Copy link

FalcoGer commented Jul 7, 2021

In orbdir.ks the function expects no parameters.
However in etaAN and etaDN, the function is called with refNorm.

How do you use those functions for time to AN/DN for equatorial orbit or any other orbit (like that of a target orbitable)?

@pand5461
Copy link
Owner

Thanks, I'll look into it.
I'd guess that refNorm is meant to be passed optionally in line 4 instead of V(0,1,0) (the equatorial normal vector).

@FalcoGer
Copy link
Author

What do you mean you'd guess? Didn't you write this? Maybe you should add more comments to your code, and especially the interface (function parameters) your code offers.

@pand5461
Copy link
Owner

pand5461 commented Sep 13, 2021

I mean, that is most likely what I meant back then.
Not 100% sure, because I haven't really played KSP for some years and I need a better PC to run the latest versions and properly test the library :(

Edit: If you could check that the fix proposed in #2 works, I'd be thoroughly grateful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants