Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for TS.RANGE's FILTER_BY_VALUE and FILTER_BY_TS parameters #30

Open
smcgovern opened this issue Jan 25, 2023 · 1 comment
Open

Comments

@smcgovern
Copy link

smcgovern commented Jan 25, 2023

Hello,

Awesome library, thanks for the work put into it. I noticed in Redis' TimeSeries documentation on TS.RANGE (https://redis.io/commands/ts.range) there is a parameter to filter results by their value FILTER_BY_VALUE. Am I mistaken in saying the current version of this package doesn't support that within its range function? https://github.com/palicao/phpRedisTimeSeries/blob/master/src/TimeSeries.php#L303

Is there a way for me to execute this, or add additional raw parameters to the end of a command?

Thanks again!

Edit:
Ah yes I now see this package is last tested against TimeSeries 1.4, and these things were added in 1.6, I'm going to review how you set this package up and try to follow best practice for adding these features, but it be great if this and LATEST, which was added in 1.8, could be implemented.

@smcgovern smcgovern changed the title TS.RANGE's FILTER_BY_VALUE and FILTER_BY_TS parameters Support for TS.RANGE's FILTER_BY_VALUE and FILTER_BY_TS parameters Jan 25, 2023
@smcgovern
Copy link
Author

smcgovern commented Jan 25, 2023

Not sure if this is best, but I implemented 2f2a1f9 on my fork to get this working in my projects. I'm sure theres other pieces to this that are worth adding that I'll encounter while digesting the redis docs, but for now this is what I've needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant