Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On PPC Tiger, old Mac OS X 10.4.11, test target does not build with GCC 4.2 #649

Closed
ballapete opened this issue Jul 20, 2024 · 2 comments · Fixed by #653
Closed

On PPC Tiger, old Mac OS X 10.4.11, test target does not build with GCC 4.2 #649

ballapete opened this issue Jul 20, 2024 · 2 comments · Fixed by #653

Comments

@ballapete
Copy link

Hello!

Other compiler option would be GCC 7.5.

Version of p11-kit is 0.25.5.

The problem is that CK_ULONG and CK_SESSION_HANDLE get redefined. I prepared the attached patch set. With it applied the default and the test target build.

See also: https://trac.macports.org/ticket/70399.

--

Pete

Patches-for-test-target-on-Tiger.diff.zip

@ballapete
Copy link
Author

The patches also work on PPC Leopard, Mac OS X 10.5.8. My test procedure was here also to invoke the port package manager with the argument test, then clean, and in the end build followed by test. So I could check that the target build succeeded and the target test could be reached directly and also via the build target.

@ueno
Copy link
Member

ueno commented Aug 2, 2024

Thank you for the report; it indeed looks like a bug. I've filed #653 to fix it.

@ueno ueno closed this as completed in #653 Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants