Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making filter function check validity of user input (especially for horoscope field) #15

Open
p-xp opened this issue Nov 3, 2023 · 0 comments

Comments

@p-xp
Copy link
Owner

p-xp commented Nov 3, 2023

The names of some horoscopes can be quite long and it is easy for users to have typos. E.g. Aquarius, Capricorn...

Furthermore, there is a clearly defined set of values that are valid for the horoscope field.

Thirdly, input validation for horoscope field is a functionality that has already been implemented for other functions (e.g. add).

Given these facts, I think it would be great if the team could look into implementing input validation for filter function as well. That way, if I filter by a horoscope but have a typo, I'll receive an error message and know to fix the typo. Otherwise, I might think I have no Dates under that horoscope but actually I just typed it wrongly.

Can be categorized under Low of Medium severity, depending on how often the user filters for horoscopes.

@p-xp p-xp changed the title filter function should check validity of user input (especially for horoscope field) Consider making filter function check validity of user input (especially for horoscope field) Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant