Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated all of the dependencies #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ragaar
Copy link

@ragaar ragaar commented Oct 30, 2018

This will close #5

Removed cross-env and used the built-in flag --mode instead. When using npm run dev the event completes but not in a way that makes it obvious the application is compiled and hosted on http://localhost:8080

This will close p-adams#5

Removed `cross-env` and used the built-in flag `--mode` instead. When using `npm run dev` the event completes but not in a way that makes it obvious the application is compiled and hosted on http://localhost:8080
@@ -1,5 +1,9 @@
{
"presets": [
["es2015", { "modules": false }]
["@babel/preset-env",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm run dev throws an error if this is not changed.

@@ -4,22 +4,23 @@
"author": "Paul Adams",
"private": true,
"scripts": {
"dev": "webpack-dev-server --inline --hot",
"build": "cross-env NODE_ENV=production webpack --progress --hide-modules"
"dev": "webpack-dev-server --mode=development --inline --hot",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm run dev complains a mode is not set. I attempted to leverage cross-env, and left in some features within webpack.config.js to leverage those. However, I have never had much luck using cross-env over the builtin flag.

"dev": "webpack-dev-server --inline --hot",
"build": "cross-env NODE_ENV=production webpack --progress --hide-modules"
"dev": "webpack-dev-server --mode=development --inline --hot",
"build": "webpack --mode=production --progress --hide-modules"
},
"dependencies": {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is overkill to detail the dependency versions in the manner that I have. Just wanted to be explicit as a sanity check.

"css-loader": "^1.0.1",
"file-loader": "^2.0.0",
"vue-loader": "^15.4.2",
"vue-template-compiler": "^2.5.17",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm run dev throws an error if this is missing.

"file-loader": "^0.8.4",
"vue-loader": "^9.2.2",
"webpack": "^2.1.0-beta.20",
"@babel/core": "^7.1.2",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@babel represents the latest namespace. I believe @VUE is in the process of migrating to this approach as well, but -- as of this PR -- has only transitioned some of the CLI packages.

var webpack = require('webpack')
const path = require('path')
const webpack = require('webpack')
const VueLoaderPlugin = require('vue-loader/lib/plugin')
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm run dev throws an error if this is missing.

},
rules: [
{ test: /\.vue$/, loader: 'vue-loader' },
{ test: /\.css$/, loader: 'css-loader' },
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm run dev throws an error if this is missing.
I don't believe the SCSS variant is needed, but it adds support for <style lang="scss" /> in vue and scss formatted file extensions. There is a citation in the documentation, but I don't have it handy.

{ test: /\.vue$/, loader: 'vue-loader' },
{ test: /\.css$/, loader: 'css-loader' },
{ test: /\.scss$/, loader: 'css-loader' },
{ test: /\.js$/, loader: 'babel-loader', exclude: /node_modules/ },
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

babel-loader can no longer be referenced as just babel.
npm run dev throws an error if this is missing.

exclude: /node_modules/
},
rules: [
{ test: /\.vue$/, loader: 'vue-loader' },
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vue-loader can no longer be referenced as just vue.
npm run dev throws an error if this is missing.

}
]
},
plugins: [
new VueLoaderPlugin()
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm run dev throws an error if this is missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[deprecated] babel-preset-es2015
1 participant