Merge pull request #14 from ozgurkara/remove-jaeger

tracing removed
ozgurkara · Jan 30, 2024 · 137ab11 · 137ab11
2 parents 47e713f + a81a4b6
commit 137ab11
Show file tree

Hide file tree

Showing 7 changed files with 5 additions and 118 deletions.
diff --git a/app/application.py b/app/application.py
@@ -6,10 +6,6 @@
 from fastapi import FastAPI
 
 from fastapi_contrib.common.middlewares import StateRequestIDMiddleware
-from fastapi_contrib.tracing.middlewares import OpentracingMiddleware
-
-from app.utils.config import TRACER_IS_ENABLED
-from app.utils.tracer_config import tracer
 from app.utils.exception.exception_handlers import ExceptionHandlers
 from app.utils.pydiator.pydiator_core_config import set_up_pydiator
 from app.utils.exception.exception_types import DataException, ServiceException
@@ -46,10 +42,6 @@ def create_app():
     @app.on_event('startup')
     async def startup():
         app.add_middleware(StateRequestIDMiddleware)
-        if TRACER_IS_ENABLED:
-            app.state.tracer = tracer
-            app.tracer = app.state.tracer
-            app.add_middleware(OpentracingMiddleware)
 
     set_up_pydiator()
 

diff --git a/app/utils/pydiator/pipelines/__init__.py b/app/utils/pydiator/pipelines/__init__.py
diff --git a/app/utils/pydiator/pipelines/tracer_pipeline.py b/app/utils/pydiator/pipelines/tracer_pipeline.py
diff --git a/app/utils/pydiator/pydiator_core_config.py b/app/utils/pydiator/pydiator_core_config.py
@@ -1,14 +1,12 @@
 from app.data.todo.usecases.delete_todo_by_id_data import DeleteTodoByIdDataUseCase, DeleteTodoByIdDataRequest
 from app.notification.todo_transaction.transaction_log_subscriber import TransactionLogSubscriber
-from app.utils.config import CACHE_PIPELINE_IS_ENABLED, TRACER_IS_ENABLED, LOG_PIPELINE_IS_ENABLED, \
-    TRACER_PIPELINE_IS_ENABLED
+from app.utils.config import CACHE_PIPELINE_IS_ENABLED, LOG_PIPELINE_IS_ENABLED
 from app.utils.cache_provider import get_cache_provider
 
 from pydiator_core.mediatr import pydiator
 from pydiator_core.mediatr_container import MediatrContainer
 from pydiator_core.pipelines.cache_pipeline import CachePipeline
 from pydiator_core.pipelines.log_pipeline import LogPipeline
-from app.utils.pydiator.pipelines.tracer_pipeline import TracerPipeline
 
 from app.resources.todo.usecases.get_todo_all import GetTodoAllRequest, GetTodoAllUseCase
 from app.resources.todo.usecases.get_todo_by_id import GetTodoByIdRequest, GetTodoByIdUseCase
@@ -27,8 +25,6 @@
 def set_up_pydiator():
     container = MediatrContainer()
 
-    if TRACER_IS_ENABLED and TRACER_PIPELINE_IS_ENABLED:
-        container.register_pipeline(TracerPipeline())
 
     if LOG_PIPELINE_IS_ENABLED:
         container.register_pipeline(LogPipeline())

diff --git a/requirements.txt b/requirements.txt
@@ -6,17 +6,11 @@ pydantic==1.7.4
 redis==3.5.3
 
 # test
-pytest==6.2.1
+pytest==8.0.0
 requests==2.31.0
-coverage==5.3.1
-pytest-env==0.6.2
-python-dotenv==0.15.0
-
-# tracing
-jaeger-client==4.4.0
-opentracing==2.4.0
-opentracing-instrumentation==3.3.1
-tornado==6.3.3
+coverage==7.4.1
+pytest-env==1.1.3
+python-dotenv==1.0.1
 
 
 

diff --git a/tests/unit/utils/pydiator/pipelines/__init__.py b/tests/unit/utils/pydiator/pipelines/__init__.py
diff --git a/tests/unit/utils/pydiator/pipelines/test_tracer_pipeline.py b/tests/unit/utils/pydiator/pipelines/test_tracer_pipeline.py