Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive eq and show for all exposed types #538

Open
aronerben opened this issue May 12, 2022 · 1 comment
Open

Derive eq and show for all exposed types #538

aronerben opened this issue May 12, 2022 · 1 comment

Comments

@aronerben
Copy link
Contributor

Deriving eq and show makes it possible for users to easily derive eq and show for their own types that depend on Sihl types. Sihl already depends on ppx_deriving, but certain sihl-* services don't, so this would incur additional dependencies for those.

@timohuber
Copy link

Deriving user with sexp (https://github.com/janestreet/ppx_sexp_conv) would be useful, too. We currently use it to store the current user in Opiums context, what requires a sexp_of_t function : https://rgrinberg.github.io/opium/rock/Rock/Context/Key/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants