Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test that inv_ tables are populated by representative collection #6636

Closed
smklein opened this issue Sep 23, 2024 · 0 comments · Fixed by #6637
Closed

Add test that inv_ tables are populated by representative collection #6636

smklein opened this issue Sep 23, 2024 · 0 comments · Fixed by #6637
Assignees
@smklein

Comments

@smklein
Copy link
Collaborator

smklein commented Sep 23, 2024 •
edited
Loading

Do you think we should have a test for the representative collection that it has rows for all inv_* tables? I'm a little afraid this test won't catch this problem in the future because someone might forget to add it to that, too. (It wouldn't have caught this specific instance for that reason, right?)

Originally posted by @davepacheco in #6632 (comment)

^ my take: yes! That's what this issue is about
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smklein smklein

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[nexus] Check that representative collection populates "inv_..." tables oxidecomputer/omicron
1 participant
@smklein