Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

saga + saga_node_event tables are never garbage collected, but they should be #6635

Open
smklein opened this issue Sep 23, 2024 · 1 comment

Comments

@smklein
Copy link
Collaborator

smklein commented Sep 23, 2024

In the spirit of #6615 , I looked at SHOW TABLES on dogfood to see where we have high-volume tables that are missing garbage collection.

In addition to the issue reported by #6615, I noticed the following tables have unusually high row counts:

  public      | saga                                              | table    | root  |             2555404 | NULL                                                                                                                              
  public      | saga_node_event                                   | table    | root  |            55688221 | NULL

I think this is "expected, but also bad". We should have a mechanism to garbage collect the tens of millions of saga events that have been created, rather than holding onto them and wasting disk space in perpetuity.

@davepacheco
Copy link
Collaborator

Yeah, we definitely should clean these up.

It would be really nice if we slurped these out of the database and saved them to a flat file (which is by comparison much cheaper to store) and potentially kept those indefinitely, or at least much longer. These could be really useful for support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants