Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconfigurator: Delete Dataset records for expunged zones #6066

Open
jgallagher opened this issue Jul 12, 2024 · 0 comments
Open

Reconfigurator: Delete Dataset records for expunged zones #6066

jgallagher opened this issue Jul 12, 2024 · 0 comments
Assignees

Comments

@jgallagher
Copy link
Contributor

#6065 ensures we create Dataset records for Omicron zones that have durable datasets, but nothing today removes records for expunged zones. @smklein noted this is more complicated for crucible zones:

e.g., the region replacement task currently does a big join of "given a region, look up the dataset, and given that dataset, look up the zpool, and given the zpool, look up the physical disk and check the policy"
so, leaving that query as-is, [we] can't actually delete the dataset rows until the region replacement task has finished

This is strongly related to #6042 (separating zone / dataset management) and lightly related to #6051 (we also never clean up Zpool rows).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants