Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blueprints should store the reasons zone dispositions were changed #5586

Open
sunshowers opened this issue Apr 20, 2024 · 0 comments
Open

Blueprints should store the reasons zone dispositions were changed #5586

sunshowers opened this issue Apr 20, 2024 · 0 comments

Comments

@sunshowers
Copy link
Contributor

sunshowers commented Apr 20, 2024

In #5493, we realized that blueprint diffs weren't quite clear about why a disposition was changed. That's because blueprints themselves don't have any persistent information about this.

To address this, we should consider storing a zone log (append-only?) next to each zone which indicates the particular blueprint an action was taken in, and why that was done.

For diffs it may be a bit confusing to see the zone log if the "before" blueprint isn't an ancestor of the "after" blueprint. We'll have to see how it looks, but may need to make blueprint diffs aware of the ancestor relationship, and enhance their output accordingly. Ancestor and cousin blueprint diffs definitely feel different to me in ways that implementing this will hopefully elaborate.

(We're reinventing bits of a source control system. :) )

@sunshowers sunshowers added this to the 9 milestone Apr 20, 2024
@morlandi7 morlandi7 modified the milestones: 9, 10 Jul 17, 2024
@morlandi7 morlandi7 removed this from the 10 milestone Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants