Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nexus_external_addresses() should use target blueprint #5220

Closed
davepacheco opened this issue Mar 7, 2024 · 0 comments
Closed

nexus_external_addresses() should use target blueprint #5220

davepacheco opened this issue Mar 7, 2024 · 0 comments
Assignees
@davepacheco

Comments

@davepacheco
Copy link
Collaborator

See #4947 (comment).

I think it's enough to accept a blueprint argument and use the external addresses of Nexus in that blueprint if present. The services table will be accurate if no target blueprint is set.

The caller should probably provide the blueprint. After #5068, it might be the target blueprint or it might be some other one that we're executing.
@davepacheco davepacheco self-assigned this Mar 7, 2024
@davepacheco davepacheco changed the title nexus_external_addreses() should use target blueprint nexus_external_addresses() should use target blueprint Mar 7, 2024
@davepacheco davepacheco mentioned this issue Mar 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davepacheco davepacheco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davepacheco