Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let Nexus decide how to deal with old partitions on new U.2s #5152

Open
smklein opened this issue Feb 27, 2024 · 2 comments
Open

Let Nexus decide how to deal with old partitions on new U.2s #5152

smklein opened this issue Feb 27, 2024 · 2 comments

Comments

@smklein
Copy link
Collaborator

smklein commented Feb 27, 2024

This will be necessary to resolve issues like #5128

Blocked by #5150 and #5151

When Nexus chooses to adopt a new physical disk into the control plane, it will have an opportunity to make a decision about "what to do with old partitions on this device". As we've seen in #5128 , not all U.2s will have uniform decisions, and it may make sense to overwrite them or ask an operator for additional input before proceeding.

@davepacheco
Copy link
Collaborator

@smklein I think this is not a blocker for the Q1 milestone. Is that right?

@smklein
Copy link
Collaborator Author

smklein commented Feb 27, 2024

@smklein I think this is not a blocker for the Q1 milestone. Is that right?

Correct - we could opt to have a strict "only adopt disks which have a specific, well-formed partition table" policy to start, and still provide the ability to arbitrarily expunge disks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants