Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v10 schema changes removed, renamed into v11 #4530

Closed
smklein opened this issue Nov 20, 2023 · 0 comments · Fixed by #4529
Closed

v10 schema changes removed, renamed into v11 #4530

smklein opened this issue Nov 20, 2023 · 0 comments · Fixed by #4529

Comments

@smklein
Copy link
Collaborator

smklein commented Nov 20, 2023

This unexpectedly caused a gap in our linear history of schema changes.

It appears #3804 removed all the 10.0.0 schema changed, and placed them into version 11.0.0, which now appears to have two sets of schema changes (up1 + up01, which should be unrelated).

This issue tracks fixing history, and also, hopefully making this harder to happen in the future?
This was referenced Nov 20, 2023
Closed
Merged
karencfv pushed a commit to karencfv/omicron that referenced this issue Nov 21, 2023
@jgallagher
Restore schema 10.0.0 (oxidecomputer#4529)
74d3bf9 
This was accidentally merged in with 11.0.0 in oxidecomputer#3804

Fixes oxidecomputer#4530 (but see oxidecomputer#4531 for followup work)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restore schema 10.0.0 oxidecomputer/omicron
1 participant
@smklein