Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oximeter could support more integer types #4058

Closed
bnaecker opened this issue Sep 8, 2023 · 1 comment
Closed

oximeter could support more integer types #4058

bnaecker opened this issue Sep 8, 2023 · 1 comment

Comments

@bnaecker
Copy link
Collaborator

bnaecker commented Sep 8, 2023

When we originally wrote oximeter, we supported the bare minimum of data types to streamline prototyping. We should really support more integer types. This should be a pretty mechanical change that adds, for each type:

  • A new oximeter::FieldType variant
  • A new oximeter::DatumType variant
  • A new oximeter::Datum variant
  • Possibly cumulative types for these, although that is probably only reasonable for the widest types
  • Possibly implement histogram support for these new integer types
  • New model types, oximeter_db::model::Db{Datum,Field}Type and field / measurement row types

The most important type to actually support is u64. We're currently limited to i64, which is really huge but technically not big enough to support some values (e.g., the kstats for bytes received on a datalink are technically a u64). But given how mechanical this all should be, I'd also argue for adding pretty much all the integral types.

@bnaecker
Copy link
Collaborator Author

Closed by #4091

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant