Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oximeter targets and metrics need versions #1293

Closed
bnaecker opened this issue Jun 28, 2022 · 2 comments
Closed

Oximeter targets and metrics need versions #1293

bnaecker opened this issue Jun 28, 2022 · 2 comments
Labels

Comments

@bnaecker
Copy link
Collaborator

The oximeter::Target and oximeter::Metric traits need to support a version number for each. Ideally, this would be easily expressed in the derive macro. The actual timeseries for a target/metric pair also needs to be versioned, but this should be derived from the version of those parts. E.g., <target_version>.<metric_version>.

This should also be included in the database representation of the timeseries schema. This will interact with the current Nexus API endpoint for listing the schema, though that may just disappear at some point.

@bnaecker
Copy link
Collaborator Author

I've posted a PR which adds versions to the target / metric types themselves. The next chunk is to read / write them in the DB when doing both insertions or queries. That will involve some tooling to update the ClickHouse schema as well, since we'll want to add columns to the timeseries_schema table to track them.

@bnaecker
Copy link
Collaborator Author

Completed in #5889

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant