From fea9ad9a12a1d7265f81fa62b33be6e39e745f63 Mon Sep 17 00:00:00 2001
From: James MacMahon <james@oxide.computer>
Date: Tue, 13 Aug 2024 19:49:35 +0000
Subject: [PATCH] log region snapshot details

---
 .../region_snapshot_replacement_start.rs      | 19 ++++++++++++++++---
 1 file changed, 16 insertions(+), 3 deletions(-)

diff --git a/nexus/src/app/background/tasks/region_snapshot_replacement_start.rs b/nexus/src/app/background/tasks/region_snapshot_replacement_start.rs
index 2d0ad80b27..0b9aa41cf9 100644
--- a/nexus/src/app/background/tasks/region_snapshot_replacement_start.rs
+++ b/nexus/src/app/background/tasks/region_snapshot_replacement_start.rs
@@ -97,7 +97,13 @@ impl RegionSnapshotReplacementDetector {
                     let s =
                         format!("error looking up replacement request: {e}");
 
-                    error!(&log, "{s}");
+                    error!(
+                        &log,
+                        "{s}";
+                        "snapshot_id" => %region_snapshot.snapshot_id,
+                        "region_id" => %region_snapshot.region_id,
+                        "dataset_id" => %region_snapshot.dataset_id,
+                    );
                     status.errors.push(s);
                     continue;
                 }
@@ -121,8 +127,9 @@ impl RegionSnapshotReplacementDetector {
                         info!(
                             &log,
                             "{s}";
-                            "region_id" => %region_snapshot.region_id,
                             "snapshot_id" => %region_snapshot.snapshot_id,
+                            "region_id" => %region_snapshot.region_id,
+                            "dataset_id" => %region_snapshot.dataset_id,
                         );
                         status.requests_created_ok.push(s);
                     }
@@ -131,7 +138,13 @@ impl RegionSnapshotReplacementDetector {
                         let s =
                             format!("error creating replacement request: {e}");
 
-                        error!(&log, "{s}");
+                        error!(
+                            &log,
+                            "{s}";
+                            "snapshot_id" => %region_snapshot.snapshot_id,
+                            "region_id" => %region_snapshot.region_id,
+                            "dataset_id" => %region_snapshot.dataset_id,
+                        );
                         status.errors.push(s);
                     }
                 }