From bcd7ac5d5e10355774310aa583aa59253eb880e5 Mon Sep 17 00:00:00 2001 From: John Gallagher Date: Wed, 6 Dec 2023 10:03:40 -0800 Subject: [PATCH] [nexus] Bump query limit for uninitialized sleds (#4626) Fixes #4621, but in a quick-and-cheesy-feels-bad way that needs more thought to fix more elegantly. --- nexus/src/app/rack.rs | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/nexus/src/app/rack.rs b/nexus/src/app/rack.rs index 95283faa1c..3804841feb 100644 --- a/nexus/src/app/rack.rs +++ b/nexus/src/app/rack.rs @@ -869,7 +869,17 @@ impl super::Nexus { ) -> ListResultVec { debug!(self.log, "Getting latest collection"); // Grab the SPs from the last collection - let limit = NonZeroU32::new(50).unwrap(); + // + // We set a limit of 200 here to give us some breathing room when + // querying for cabooses and RoT pages, each of which is "4 per SP/RoT", + // which in a single fully populated rack works out to (32 sleds + 2 + // switches + 1 psc) * 4 = 140. + // + // This feels bad and probably needs more thought; see + // https://github.com/oxidecomputer/omicron/issues/4621 where this limit + // being too low bit us, and it will link to a more general followup + // issue. + let limit = NonZeroU32::new(200).unwrap(); let collection = self .db_datastore .inventory_get_latest_collection(opctx, limit)