From a972c80c407b68848c178aca236ae00067bc4d3b Mon Sep 17 00:00:00 2001
From: Andy Fiddaman <andy@oxidecomputer.com>
Date: Wed, 11 Oct 2023 17:59:57 +0100
Subject: [PATCH] destroy_virtual_hardware.sh needs to unmount backing
 filesystems (#4255)

The backing filesystems added in d624bce9af2 prevent the
destroy_virtual_hardware.sh script from properly cleaning up all ZFS
pools and cause the fmd service to go into maintenance which delays
control plane startup. This updates the script to unwind the backing
datasets as part of its work.
---
 tools/destroy_virtual_hardware.sh | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/tools/destroy_virtual_hardware.sh b/tools/destroy_virtual_hardware.sh
index ae6fef0673..46c6f117c4 100755
--- a/tools/destroy_virtual_hardware.sh
+++ b/tools/destroy_virtual_hardware.sh
@@ -56,7 +56,23 @@ function remove_softnpu_zone {
         --ports sc0_1,tfportqsfp0_0
 }
 
+# Some services have their working data overlaid by backing mounts from the
+# internal boot disk. Before we can destroy the ZFS pools, we need to unmount
+# these.
+
+BACKED_SERVICES="svc:/system/fmd:default"
+
+function demount_backingfs {
+    svcadm disable -st $BACKED_SERVICES
+    zpool list -Hpo name | grep '^oxi_' \
+        | xargs -i zfs list -Hpo name,canmount,mounted -r {}/backing \
+        | awk '$3 == "yes" && $2 == "noauto" { print $1 }' \
+        | xargs -l zfs umount
+    svcadm enable -st $BACKED_SERVICES
+}
+
 verify_omicron_uninstalled
+demount_backingfs
 unload_xde_driver
 remove_softnpu_zone
 try_remove_vnics