From a6716e323fde83dc4b7d322993901975c37a12a7 Mon Sep 17 00:00:00 2001
From: Rain <rain@sunshowers.io>
Date: Fri, 17 Nov 2023 15:46:06 -0800
Subject: [PATCH] Address review comments

Created using spr 1.3.5
---
 wicketd/src/http_entrypoints.rs | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/wicketd/src/http_entrypoints.rs b/wicketd/src/http_entrypoints.rs
index cff0436dac..dbd3e31072 100644
--- a/wicketd/src/http_entrypoints.rs
+++ b/wicketd/src/http_entrypoints.rs
@@ -904,7 +904,8 @@ async fn post_start_update(
     //    out of an abundance of caution).
     //
     // First, get our most-recently-cached inventory view. (Only wait 80% of
-    // WICKETD_TIMEOUT for this -- if the inventory isn't available, then we
+    // WICKETD_TIMEOUT for this: if even a cached inventory isn't available,
+    // it's because we've never established contact with MGS. In that case, we
     // should produce a useful error message rather than timing out on the
     // client.)
     let inventory = match tokio::time::timeout(
@@ -921,12 +922,16 @@ async fn post_start_update(
             ));
         }
         Err(_) => {
-            // Use 400 Bad Request instead of 503 Service Unavailable so that
-            // the error message is propagated to the client.
-            return Err(HttpError::for_bad_request(
-                None,
-                "Rack inventory not yet available (is MGS alive?)".into(),
-            ));
+            // Have to construct an HttpError manually because
+            // HttpError::for_unavail doesn't accept an external message.
+            let message =
+                "Rack inventory not yet available (is MGS alive?)".to_owned();
+            return Err(HttpError {
+                status_code: http::StatusCode::SERVICE_UNAVAILABLE,
+                error_code: None,
+                external_message: message.clone(),
+                internal_message: message,
+            });
         }
     };