Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgadm should handle API errors gracefully #362

Open
rcgoodfellow opened this issue Sep 10, 2024 · 0 comments
Open

mgadm should handle API errors gracefully #362

rcgoodfellow opened this issue Sep 10, 2024 · 0 comments
Labels
Bug mgd Maghemite daemon

Comments

@rcgoodfellow
Copy link
Collaborator

There are several places like this in the mgadm code where we unwrap API calls like this.

let response = c.read_router(asn).await.unwrap();

This results in a crash and corefile when the API returns an error, even for something like a 400 error. While mgadm is just a local debugging tool, this is not ideal as it leaves core files around which show up in rack health checks.

@rcgoodfellow rcgoodfellow added Bug mgd Maghemite daemon labels Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug mgd Maghemite daemon
Projects
None yet
Development

No branches or pull requests

1 participant