Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistencies in tech port unlock behavior #1839

Open
mkeeter opened this issue Aug 9, 2024 · 0 comments
Open

Inconsistencies in tech port unlock behavior #1839

mkeeter opened this issue Aug 9, 2024 · 0 comments

Comments

@mkeeter
Copy link
Collaborator

mkeeter commented Aug 9, 2024

control-plane-agent and net store unlock state on a per-VLAN basis. However, monorail does not; it enables all tech ports when unlocked. This could be confusing if someone sends unlock commands on multiple ports; monorail's time-based unlock will fire at the time set by the most recent unlock.

We should either

  • Make monorail smarter (configuring the VLANs to enable one or both tech ports, instead of always enabling both), or
  • Make the other tasks dumber, with a single locked / unlocked state controlling their behavior

I'm leaning towards the latter, because it's hard to imagine a case where someone authorized is connected to TP1 and someone malicious is connected to TP2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant