Use regions_dataset path for apply_smf #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`apply_smf`'s `dataset` argument is meant to be for the regions dataset, not the specific region dataset. Additionally, panic if regions_dataset.path() returns Err: the agent requires a valid regions dataset and path to work.
leftwo
approved these changes
Oct 13, 2023
| let regions_dataset_path = match regions_dataset.path() { | ||
| Ok(regions_dataset_path) => regions_dataset_path, | ||
| Err(e) => { | ||
| panic!( |
There was a problem hiding this comment.
So, this will panic right at the start if the specific regions dataset path does not
exist before we even begin then, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apply_smf'sdatasetargument is meant to be for the regions dataset,not the specific region dataset.
Additionally, panic if regions_dataset.path() returns Err: the agent
requires a valid regions dataset and path to work.
Fixes #999