App store unit tests (first batch) #11752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
JammingBen
reviewed
Oct 10, 2024
|
|
||
| const mocks = { | ||
| ...defaultComponentMocks(), | ||
| loadApps |
There was a problem hiding this comment.
Do you really need to provide loadApps here?
kulmann
force-pushed
the
app-store-unit-tests
branch
from
99d5567
to
d2cd416
Compare
kulmann
force-pushed
the
app-store-unit-tests
branch
from
d2cd416
to
0fdcd37
Compare
|
JammingBen
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a few unit tests for the app store... far from "done", but since I need to switch to a different task I probably won't add more coverage in the next few days. So trying to get the current state into master.
Issues
Works towards #11634