Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Pipeline design-system-build-and-tests missing test execution script #11971

Closed
amrita-shrestha opened this issue Nov 27, 2024 · 7 comments · Fixed by #11974
Closed

[CI] Pipeline design-system-build-and-tests missing test execution script #11971

amrita-shrestha opened this issue Nov 27, 2024 · 7 comments · Fixed by #11974
Assignees
Labels

Comments

@amrita-shrestha
Copy link
Contributor

Describe the bug

In the Drone pipeline design-system-build-and-tests, no tests are being executed. It seems the script was removed in the past. If this was intentional, why does the pipeline still exist?
design-system-build-and-tests pipeline introduced in this PR #10374

Drone Error

+ pnpm --filter @ownclouders/design-system test:e2e
None of the selected packages has a "test:e2e" script

Screenshot from 2024-11-27 12-18-40

cc @JammingBen @kulmann @LukasHirt

@JammingBen
Copy link
Collaborator

This CI step is to make sure the design-system successfully builds. In the future me might add a step to publish it to https://owncloud.design. However, there are no specific e2e or unit tests, so this step can be removed.

@saw-jan
Copy link
Member

saw-jan commented Nov 27, 2024

what about these tests? get rid of them?
https://github.com/owncloud/web/tree/master/packages/design-system/tests/e2e/specs

@JammingBen
Copy link
Collaborator

Huh, I didn't even know they existed. I'd say yes - we don't really need tests for the docs part of the design system, especially not e2e tests.

@saw-jan
Copy link
Member

saw-jan commented Nov 27, 2024

It was added in #10374

@JammingBen
Copy link
Collaborator

It was added in #10374

Ah, now I remember. Still, I stand by what I said, there's no need for e2e tests as of now.

@saw-jan
Copy link
Member

saw-jan commented Nov 27, 2024

okey, got it

@saw-jan
Copy link
Member

saw-jan commented Nov 27, 2024

Huh, I didn't even know they existed. I'd say yes - we don't really need tests for the docs part of the design system, especially not e2e tests.

CC @amrita-shrestha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants