Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview app is not respecting filter on Shared with me page #11883

Open
ScharfViktor opened this issue Nov 11, 2024 · 2 comments · Fixed by #11893
Open

Preview app is not respecting filter on Shared with me page #11883

ScharfViktor opened this issue Nov 11, 2024 · 2 comments · Fixed by #11893
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working

Comments

@ScharfViktor
Copy link
Contributor

ocis 7.0.0-rc.1+22d80256d
web 11.0.2

Steps:

  • admin shares folder image files to einstein
  • einstein opens one image file in preview app and tries to scroll through all the images of the shares jail

Expected: einstein can scroll through all the images of the shares jail
Actual:

Screen.Recording.2024-11-11.at.12.39.12.mov

another strange thing:

  • admin share folder f1 with two image files
  • einstein opens first image file

Actual: he cannot scroll through two images

  • einstein opens second image file

Actual: he can scroll through two images

Screen.Recording.2024-11-11.at.12.42.19.mov
@ScharfViktor
Copy link
Contributor Author

I can confirm that it's work but I noticed several another problem:

  1. user cannot open concrete image
    Steps:
  • admin shares several image files to einstein
  • einstein opens Shares with me page and tries to open second (or last image)

Actual:
first image opens

Screen.Recording.2024-11-21.at.13.07.15.mov
  1. hidden files in the preview app
  • einstein hiddes shared file
  • einstein opens preview app

Actual: hidden file is in the app

  1. secure view files in the preview app
  • admin shares image file with secure view role to einstein
  • einstein opens any image file in the preview app

Actual: secure view files in the preview app

@ScharfViktor ScharfViktor reopened this Nov 21, 2024
@github-project-automation github-project-automation bot moved this from Done to In progress in Infinite Scale Team Board Nov 21, 2024
@ScharfViktor ScharfViktor moved this from In progress to Prio 2 in Infinite Scale Team Board Nov 21, 2024
@JammingBen JammingBen added Priority:p3-medium Normal priority and removed Priority:p2-high Escalation, on top of current planning, release blocker labels Nov 21, 2024
@JammingBen JammingBen moved this from Prio 2 to Prio 3 or less in Infinite Scale Team Board Nov 21, 2024
@JammingBen JammingBen added Priority:p2-high Escalation, on top of current planning, release blocker and removed Priority:p3-medium Normal priority labels Nov 21, 2024
@JammingBen JammingBen moved this from Prio 3 or less to In progress in Infinite Scale Team Board Nov 21, 2024
@JammingBen
Copy link
Collaborator

JammingBen commented Nov 21, 2024

I fixed issues 1. & 3. via #11947.

Issue 2 is a known issue for now, respecting the filters would take much more effort. Making it a p3 for that reason.

@JammingBen JammingBen added Priority:p3-medium Normal priority and removed Priority:p2-high Escalation, on top of current planning, release blocker labels Nov 21, 2024
@JammingBen JammingBen removed their assignment Nov 21, 2024
@JammingBen JammingBen moved this from In progress to Prio 3 or less in Infinite Scale Team Board Nov 21, 2024
@JammingBen JammingBen changed the title User cannot scroll through all the images in Shares Preview app is not respecting filter on Shared with me page Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working
Projects
Status: Prio 3 or less
Development

Successfully merging a pull request may close this issue.

2 participants