From 66a2ce9160f6dbf7022c98412d16592cdc0b085f Mon Sep 17 00:00:00 2001
From: panagiotisbellias <belliaspan@gmail.com>
Date: Wed, 10 Apr 2024 11:42:05 +0300
Subject: [PATCH 1/5] [#39] Fix two sonar cloud issues

---
 src/components/DicomControls.vue   | 28 ----------------------------
 src/components/MetadataSidebar.vue |  1 +
 2 files changed, 1 insertion(+), 28 deletions(-)

diff --git a/src/components/DicomControls.vue b/src/components/DicomControls.vue
index d4fb050e..ab1a11a3 100644
--- a/src/components/DicomControls.vue
+++ b/src/components/DicomControls.vue
@@ -4,34 +4,6 @@
       class="oc-background-brand oc-p-s oc-width-large oc-flex oc-flex-middle oc-flex-center oc-flex-around preview-controls-action-bar"
     >
       <!-- hide prev / next section while functionality is not yet implemented, set class of the wrapper div to 'oc-width-xlarge' once that section is activated -->
-      <!--
-      <div class="oc-flex oc-flex-middle">
-        <oc-button
-          v-oc-tooltip="previousDescription"
-          class="preview-controls-previous"
-          appearance="raw-inverse"
-          variation="brand"
-          :aria-label="previousDescription"
-          @click="$emit('togglePrevious')"
-        >
-          <oc-icon size="large" name="arrow-drop-left" variation="inherit" />
-        </oc-button>
-        <p v-if="!isFolderLoading" class="oc-m-rm preview-controls-action-count">
-          <span aria-hidden="true" v-text="ariaHiddenFileCount" />
-          <span class="oc-invisible-sr" v-text="screenreaderFileCount" />
-        </p>
-        <oc-button
-          v-oc-tooltip="nextDescription"
-          class="preview-controls-next"
-          appearance="raw-inverse"
-          variation="brand"
-          :aria-label="nextDescription"
-          @click="$emit('toggleNext')"
-        >
-          <oc-icon size="large" name="arrow-drop-right" variation="inherit" />
-        </oc-button>
-      </div>
-      -->
       <div class="oc-flex oc-flex-middle">
         <oc-button
           v-oc-tooltip="imageShrinkDescription"
diff --git a/src/components/MetadataSidebar.vue b/src/components/MetadataSidebar.vue
index ff228e5e..1528758f 100644
--- a/src/components/MetadataSidebar.vue
+++ b/src/components/MetadataSidebar.vue
@@ -26,6 +26,7 @@
     </div>
     <div v-if="isMetadataExtracted" id="dicom-metadata-sidebar-content" class="oc-p-s">
       <table class="details-table">
+        <caption>Details table</caption>
         <metadata-sidebar-table-row
           v-bind="$props.patientInformation"
           :metadata-section-name="'Patient Information'"

From 100edcb0734e5f674eb659895c93658602f8688d Mon Sep 17 00:00:00 2001
From: Panagiotis Bellias <panagiotis.bellias@eurodyn.com>
Date: Thu, 11 Apr 2024 09:25:30 +0300
Subject: [PATCH 2/5] [#39] Fix reviewing points

---
 src/components/DicomControls.vue   | 1 -
 src/components/MetadataSidebar.vue | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/components/DicomControls.vue b/src/components/DicomControls.vue
index ab1a11a3..bf69c560 100644
--- a/src/components/DicomControls.vue
+++ b/src/components/DicomControls.vue
@@ -3,7 +3,6 @@
     <div
       class="oc-background-brand oc-p-s oc-width-large oc-flex oc-flex-middle oc-flex-center oc-flex-around preview-controls-action-bar"
     >
-      <!-- hide prev / next section while functionality is not yet implemented, set class of the wrapper div to 'oc-width-xlarge' once that section is activated -->
       <div class="oc-flex oc-flex-middle">
         <oc-button
           v-oc-tooltip="imageShrinkDescription"
diff --git a/src/components/MetadataSidebar.vue b/src/components/MetadataSidebar.vue
index 1528758f..cc14e4c2 100644
--- a/src/components/MetadataSidebar.vue
+++ b/src/components/MetadataSidebar.vue
@@ -26,7 +26,7 @@
     </div>
     <div v-if="isMetadataExtracted" id="dicom-metadata-sidebar-content" class="oc-p-s">
       <table class="details-table">
-        <caption>Details table</caption>
+        <caption>DICOM-metadata-details-table</caption>
         <metadata-sidebar-table-row
           v-bind="$props.patientInformation"
           :metadata-section-name="'Patient Information'"

From 314344564283fdf33c1a30afb43b90999a1feb70 Mon Sep 17 00:00:00 2001
From: Panagiotis Bellias <panagiotis.bellias@eurodyn.com>
Date: Thu, 11 Apr 2024 09:38:09 +0300
Subject: [PATCH 3/5] [39] Fix drone build

---
 src/components/MetadataSidebar.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/components/MetadataSidebar.vue b/src/components/MetadataSidebar.vue
index cc14e4c2..8563489f 100644
--- a/src/components/MetadataSidebar.vue
+++ b/src/components/MetadataSidebar.vue
@@ -26,7 +26,7 @@
     </div>
     <div v-if="isMetadataExtracted" id="dicom-metadata-sidebar-content" class="oc-p-s">
       <table class="details-table">
-        <caption>DICOM-metadata-details-table</caption>
+        <caption>⏎··········DICOM metadata details table⏎········</caption>
         <metadata-sidebar-table-row
           v-bind="$props.patientInformation"
           :metadata-section-name="'Patient Information'"

From a2895c02b7d0f53847d17af3ac0164b45edeb21f Mon Sep 17 00:00:00 2001
From: panagiotisbellias <belliaspan@gmail.com>
Date: Thu, 11 Apr 2024 09:39:12 +0300
Subject: [PATCH 4/5] [39] Fix drone build

---
 src/components/MetadataSidebar.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/components/MetadataSidebar.vue b/src/components/MetadataSidebar.vue
index 8563489f..a71d72de 100644
--- a/src/components/MetadataSidebar.vue
+++ b/src/components/MetadataSidebar.vue
@@ -26,7 +26,7 @@
     </div>
     <div v-if="isMetadataExtracted" id="dicom-metadata-sidebar-content" class="oc-p-s">
       <table class="details-table">
-        <caption>⏎··········DICOM metadata details table⏎········</caption>
+        <caption>··········DICOM metadata details table········</caption>
         <metadata-sidebar-table-row
           v-bind="$props.patientInformation"
           :metadata-section-name="'Patient Information'"

From 4f6ea5ad7250695d5162223ab4bdca719318c25c Mon Sep 17 00:00:00 2001
From: panagiotisbellias <belliaspan@gmail.com>
Date: Thu, 11 Apr 2024 09:41:31 +0300
Subject: [PATCH 5/5] [#39] Fix drone build

---
 src/components/MetadataSidebar.vue | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/components/MetadataSidebar.vue b/src/components/MetadataSidebar.vue
index a71d72de..13c6344b 100644
--- a/src/components/MetadataSidebar.vue
+++ b/src/components/MetadataSidebar.vue
@@ -25,8 +25,8 @@
       </oc-button>
     </div>
     <div v-if="isMetadataExtracted" id="dicom-metadata-sidebar-content" class="oc-p-s">
-      <table class="details-table">
-        <caption>··········DICOM metadata details table········</caption>
+      <p id="mydesc">DICOM metadata details table</p>
+      <table class="details-table" aria-describedby="mydesc">
         <metadata-sidebar-table-row
           v-bind="$props.patientInformation"
           :metadata-section-name="'Patient Information'"