Do not create __apps dir.

[VicDeo]

Depends on #346
Fixes #264
Fixes #336
Fixes #290
Closes #332

takes care of #336 (comment)

• we should replace all shipped apps at once and run upgrade once - doing this step by step is wrong

[mention-bot]

By analyzing the blame information on this pull request, we identified @Phiber2000, @LukasReschke and @scrutinizer-auto-fixer to be potential reviewers

[Phiber2000]

Code looks fine.
(Just the var comments appear a bit inconsistent by comparison.)

[VicDeo]

@Phiber2000 Thanks, but it's not 100% completed yet :)

[Phiber2000]

I was afraid. But it's a nice start fixing this ugly folder workaround!
I hope there will not be too much trouble with apps...

[VicDeo]

Finally

[VicDeo]

@DeepDiver1975 @PVince81 @LukasReschke

[PVince81]

How to test ?

[VicDeo]

@PVince81

1. Install https://download.owncloud.org/community/owncloud-daily-stable9.zip
2. Switch update channel to daily
3. Override Feed url https://github.com/owncloud/updater/blob/master/src/Utils/Feed.php#L108 with 'https://download.owncloud.org/community/owncloud-daily-master.zip'
4. php updater/application.php upgrade:start

[davitol]

@VicDeo The patch did not worked for me following your steps above

This was the output:

cURL error 3: malformed
Done

Please feel free to chat with me via IRC related to my test or my test environment

[VicDeo]

@davitol
https://github.com/owncloud/updater/blob/master/src/Utils/Feed.php#L108
return $this->url;
should be replaced with
return 'https://download.owncloud.org/community/owncloud-daily-master.zip';

[davitol]

@davitol
https://github.com/owncloud/updater/blob/master/src/Utils/Feed.php#L108
return $this->url;
should be replaced with
return 'https://owncloud.org/community/owncloud-daily-master.zip';

@VicDeo already done

[VicDeo]

@davitol.. oops wrong links.
The correct are
https://download.owncloud.org/community/owncloud-daily-stable9.zip
https://download.owncloud.org/community/owncloud-daily-master.zip

Updated the steps above

[davitol]

@VicDeo in your comment #347 (comment)
seems to have the sames steps than before even when it has been edited

[davitol]

@VicDeo

[VicDeo]

@davitol try adding sudo -u www-data as suggested

[davitol]

@VicDeo Yes, this time i forgot to change the user and www-data solved the previous screenshot, but the error:
cURL error 3: malformed
keeps happening when running the command.

[davitol]

@VicDeo Trying again from zero and following the steps, this is what I got while running:
php updater/application.php upgrade:start

Starting code integrity check...
Finished code integrity check
Update successful
Turned off maintenance mode
Reset log level

PHP Fatal error:  Call to protected method Owncloud\Updater\Utils\Checkpoint::getCheckpointPath() from context 'Owncloud\Updater\Command\EnableNotShippedAppsCommand' in /opt/owncloud/updater/src/Command/EnableNotShippedAppsCommand.php on line 52

[VicDeo]

@davitol er. #346 has been not ported to stable9 yet.
(and is not shipped with daily)

[davitol]

👍 Tested and works

[VicDeo]

@DeepDiver1975 @LukasReschke @PVince81 more reviewers plz 🎅

[PVince81]

Code looks fine 👍

[PVince81]

@karlitschek @LukasReschke @DeepDiver1975 backport to 9.0.3 ?

[karlitschek]

i think this makes sense. please backport 👍

[VicDeo]

Stable9: #352

[wolfsden3]

Why is this crap so buggy? Seriously you guys don't test this stuff? I get this:
[Symfony\Component\Process\Exception\ProcessFailedException]
The command "php /var/www/owncloud/occ --no-warnings app:list --output=json
'--shipped false'" failed.
Exit Code: 1(General error)
Output:

Error Output:

[Symfony\Component\Console\Exception\RuntimeException]
The "--shipped false" option does not exist.

app:list [--output [OUTPUT]] [--shipped SHIPPED]

...I don't understand how an upgrade for you could be so smooth when everyone elses installation is borked like mine!

[PVince81]

@wolfsden3 https://owncloud.org/community/code-of-conduct/

Upgrades were tested with the updater and they worked in many environments. If they didn't in your specific environment, the only helpful thing you could do here is provide more information about it.

[wolfsden3]

If I don't use your updater and use the one in the OC 9 manual my upgrade now works where before it did not so the stable 9.1 on the website is broken in my opinion for Ubuntu. I've been trying to fix the stupid no smb mount (external storage not available error) which is a whole host of other bugs and this is all just so frustrating including the error I got with your fixes that supposedly fixed my problem and didn't. External storage works in 8.x so maybe I'll dump my Ubuntu 16 install and OC 9.x.

SMB bug: owncloud/core#21481

Anyway...my upgrade works if I don't use your updater so I'm not sure what your updater fixes!

/var/www/owncloud# sudo -u www-data php occ upgrade
ownCloud or one of the apps require upgrade - only a limited number of commands are available
You may use your browser or the occ upgrade command to do the upgrade
Set log level to debug
Checking whether the database schema can be updated (this can take a long time depending on the database size)
Checked database schema update
Checking updates of apps
Checked database schema update for apps
Updating database schema
Updated database
Starting code integrity check...
Finished code integrity check
Update successful
Maintenance mode is kept active
Reset log level

I then take it out of maintenance mode and start Apache2 and it works again but the SMB mount still doesn't. I'm still looking online for fixes but not coming up with anything.

I'm not expecting you to help with the SMB issue just letting people know your updater isn't a fix for everyone I guess.