This repository has been archived by the owner on Jan 27, 2021. It is now read-only.
add staticcheck to makefile #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
I think you wanted to address @micbar |
|
this is my list https://github.com/owncloud/enterprise/issues/4019 |
|
@butonic is that meant to be run in CI? because we have another staticcheck running already there. https://github.com/owncloud/ocis-proxy/blob/master/.drone.star#L64 |
|
I don't know if it is supposed to be executed using make staticcheck, but we have that target in several other repos ... it is just missing from this one: https://github.com/search?l=Makefile&q=org%3Aowncloud+staticcheck&type=Code |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @mbarz because I don't know what else needs to be done ...