Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocis 5 adaptions #505

Merged
merged 4 commits into from
Mar 18, 2024
Merged

ocis 5 adaptions #505

merged 4 commits into from
Mar 18, 2024

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Mar 15, 2024 •
edited
Loading

Description

  • drop the store service in favor of the general store / cache interface (default nats-js)
  • configure nats stream replicas for caches that have been recently added
  • expose enhanced s3ng options that got introduced with oCIS 5

Related Issue

Motivation and Context

How Has This Been Tested?

  • run nats-js example in minikube
  • run ocis chart connected to s3 in real cluster

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation generated (make docs) and committed
  • Documentation ticket raised:
  • Documentation PR created:

@wkloucek wkloucek changed the title configure signing-key store ocis 5 adaptions Mar 15, 2024
This was referenced Mar 15, 2024
Open
Closed
@wkloucek wkloucek requested a review from d7oc March 15, 2024 16:06
@wkloucek wkloucek marked this pull request as ready for review March 18, 2024 06:15
@wkloucek wkloucek requested review from case0sh and nazliyanik March 18, 2024 06:19
d7oc
d7oc approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@d7oc d7oc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wkloucek wkloucek merged commit c0e7b89 into next Mar 18, 2024
1 check passed
@wkloucek wkloucek deleted the signing-key-store branch March 18, 2024 10:56
@wkloucek wkloucek mentioned this pull request Mar 18, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d7oc d7oc d7oc approved these changes

@case0sh case0sh Awaiting requested review from case0sh

@nazliyanik nazliyanik Awaiting requested review from nazliyanik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkloucek @d7oc