Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix/fp-no-account] Show message in File Provider if no account has been set up #1306

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

felix-schwarz
Copy link
Contributor

Description

This PR makes the File Provider UI show a message if no account has been set up yet, offering to open the app. Previously, the FP UI was briefly shown and then dismissed.

Related Issue

Screenshots (if appropriate):

Simulator Screenshot - iPhone 15 Plus - 2023-11-28 at 12 24 20

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

- CancelLabelViewController: allow customizing the button label and use a proper type for the cancelAction
- DocumentActionViewController:
	- refactor to allow custom button label and custom action
	- show message and open app if no account has been set up in the app yet
@felix-schwarz felix-schwarz requested a review from hosy November 28, 2023 11:24
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@michaelstingl michaelstingl added this to the 12.1-Current milestone Nov 28, 2023
@jesmrec
Copy link
Contributor

jesmrec commented Nov 28, 2023

some basic cases tested here:

  • Fresh install (no accounts)
  • All accounts removed
  • With sec method

approved on my side

@jesmrec jesmrec mentioned this pull request Nov 28, 2023
36 tasks
@jesmrec jesmrec added the Approved by QA Approved by QA label Nov 28, 2023
@hosy hosy merged commit 07cf897 into feature/account-wizard Dec 1, 2023
2 of 5 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/fp-no-account branch December 1, 2023 11:10
@jesmrec jesmrec mentioned this pull request Apr 24, 2024
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved by QA Approved by QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants